Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for custom NavigationBar #23

Open
maheshj01 opened this issue Mar 13, 2023 · 1 comment
Open

Support for custom NavigationBar #23

maheshj01 opened this issue Mar 13, 2023 · 1 comment
Labels
Feature Request New feature or request P1 High Priority: Something is severely broken and unusable requires immediate fix.

Comments

@maheshj01
Copy link
Owner

This issue is similar to #8

Is your feature request related to a problem? Please describe.

Although NavbarRouter adds support for different NavigationBars going forward, users have different design specs for their apps which prevents them from using this package. We should Add support for a custom NavigationBar which users should implement from NavbarBase and pass to NavbarRouter this will allow users to add their own NavigationBar and yet use all the features of this package.

Describe the solution you'd like
Perhaps we should add a NavbarRouter.custom constructor which also takes in NavBarBase as a parameter to support this request.

@maheshj01 maheshj01 added the Feature Request New feature or request label Mar 13, 2023
@maheshj01 maheshj01 added the P1 High Priority: Something is severely broken and unusable requires immediate fix. label Feb 11, 2024
@maheshj01
Copy link
Owner Author

I think the right way to implement this would be to add a NavbarRouter.custom with a required widget parameter that extends from NavbarBase and user must implement a build method in it. This widget should be passed to the animatedNavbar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New feature or request P1 High Priority: Something is severely broken and unusable requires immediate fix.
Projects
None yet
Development

No branches or pull requests

1 participant