Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: jumpstart sets must use shared code to generate single boosters #13264

Open
1 of 5 tasks
JayDi85 opened this issue Jan 27, 2025 · 0 comments
Open
1 of 5 tasks
Labels
enhancement refactoring Developers topics about code and programming

Comments

@JayDi85
Copy link
Member

JayDi85 commented Jan 27, 2025

Jumpstart is special booster type of x20 cards. Cards split by themes instead random:
https://mtg.fandom.com/wiki/Jumpstart

Xmage support it by special jumpstart game mode only (see JumpstartPoolGenerator and \resources\jumpstart\jumpstart.txt).

Problems

  1. There are 3 jumpstart sets, but only 1 supported:
    • 2020 - Jumpstart
    • 2022 - Jumpstart 2022
    • 2024 - Foundations Jumpstart
  2. Jumpstart boosters supported by special game mode instead any;

What can be done:

  • improved code of JumpstartPoolGenerator to use predefined boosters from all 3 sets instead 1;
  • override createBooster and use shared code from JumpstartPoolGenerator to generate single boosters (see code example from MysteryBooster);
  • so jumpstart boosters can be used in all other game modes after improve;
@JayDi85 JayDi85 added enhancement refactoring Developers topics about code and programming labels Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement refactoring Developers topics about code and programming
Projects
None yet
Development

No branches or pull requests

1 participant