Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: intervening if triggered abilities #13041

Open
xenohedron opened this issue Oct 27, 2024 · 0 comments
Open

refactor: intervening if triggered abilities #13041

xenohedron opened this issue Oct 27, 2024 · 0 comments
Labels
refactoring Developers topics about code and programming

Comments

@xenohedron
Copy link
Contributor

Old way: ConditionalInterveningIfTriggeredAbility as wrapper class with hardcoded rules text

New way: withInterveningIf(Condition interveningIfCondition) chaining method for any TriggeredAbility with auto generated text

See #13037 for initial demonstration

Huge number of usages so refactoring will be a gradual process.
@xenohedron xenohedron added the refactoring Developers topics about code and programming label Oct 27, 2024
@xenohedron xenohedron mentioned this issue Oct 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring Developers topics about code and programming
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xenohedron