You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
All code with spell's copy check is outdated, cause current engine uses really new cards for copies (old code used original card, so that check required). So spell copy check must be removed as outdated. Also manual remove from stack must be removed too -- card moving code already processing it.
Many use cases with counter of spell's copy is not covered by tests (no breakpoints at all on debug). So outdate code remove must help with it. If some check code will keep exists then it must be covered by tests like 701bd68.
TODO:
remove all calls of getStack().remove from outside of inner game engine
make sure counter of copied spells covered by tests (it must counter and save LKI for next effects);
review all use of isCopy() and remove outdate code (with spells, with another objects, etc);
The text was updated successfully, but these errors were encountered:
After Swan Song fix f85a707 from #12883 found many problems:
Looks like original spell LKI implementation is not fully implemented (also related to Unbound Flourishing's PR Unbound Flourishing's X doubling should be a triggered ability (and related refactors) #12597) -- there are many places with stack removing without LKI save, search by
![shot_240925_095711](https://private-user-images.githubusercontent.com/8344157/370578359-07320d39-cdc0-42be-8775-ee4a099d6666.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5MDUwMTIsIm5iZiI6MTczODkwNDcxMiwicGF0aCI6Ii84MzQ0MTU3LzM3MDU3ODM1OS0wNzMyMGQzOS1jZGMwLTQyYmUtODc3NS1lZTRhMDk5ZDY2NjYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIwNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMDdUMDUwNTEyWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YzAyYjNmMWU3YWEyNmI2MTRjNGQ4ZGFkYzA3NDMxYTAyNWVjODQzNTIyYzc5MmQ2ZWFhNDNhYmRkNmNiMWE5YiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.M2L-YDsXn8Y991yfAIn54dojEustmW64wpCtVH_sB3o)
getStack().remove
. All that places require same fix as Swan Song above.All code with spell's copy check is outdated, cause current engine uses really new cards for copies (old code used original card, so that check required). So spell copy check must be removed as outdated. Also manual remove from stack must be removed too -- card moving code already processing it.
![shot_240925_100348](https://private-user-images.githubusercontent.com/8344157/370580005-112d7141-a385-46e4-aa51-d2694bcb6fa5.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5MDUwMTIsIm5iZiI6MTczODkwNDcxMiwicGF0aCI6Ii84MzQ0MTU3LzM3MDU4MDAwNS0xMTJkNzE0MS1hMzg1LTQ2ZTQtYWE1MS1kMjY5NGJjYjZmYTUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIwNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMDdUMDUwNTEyWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NDUzZGYzYzVmNjI0N2IyMTJiZWJhYWI0MGJiNTY1MmEyYzUzMTE3MTBlOGJmMjk1NjAzZDliZGMxMGI5YzNhZCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.fNhv3Nr6zdPZ05Ry5Ehhx1c8KPKJ8qg7KczzaWnTZcc)
![shot_240925_100959](https://private-user-images.githubusercontent.com/8344157/370582349-23418758-96eb-4de2-bee1-5f50f382fb41.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5MDUwMTIsIm5iZiI6MTczODkwNDcxMiwicGF0aCI6Ii84MzQ0MTU3LzM3MDU4MjM0OS0yMzQxODc1OC05NmViLTRkZTItYmVlMS01ZjUwZjM4MmZiNDEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIwNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMDdUMDUwNTEyWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZmYyYzVhMGE2ZGYzZmJkMzRkMTdkNTgzMGIyMWYwMGQ1MGVmMGU1ODFjNDlkNzhiZjVkM2RhMjlmODQ2ZTIwMiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.VciBXoiygdIeps4M8p_tdQK9HmDVsjRNZ2ME1eKhwRM)
Many use cases with counter of spell's copy is not covered by tests (no breakpoints at all on debug). So outdate code remove must help with it. If some check code will keep exists then it must be covered by tests like 701bd68.
TODO:
getStack().remove
from outside of inner game engineisCopy()
and remove outdate code (with spells, with another objects, etc);The text was updated successfully, but these errors were encountered: