-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework drawing cards, associated replacement effects, and removing cards from library; implement [WHO] River Song #12700
Conversation
remove outdated MageAction framework clarify game event for drawing two or more cards
Grenzo, Dungeon Warden - (Gatherer) (Scryfall) (EDHREC)
|
@@ -54,7 +54,7 @@ public boolean apply(Game game, Ability source) { | |||
return true; | |||
} | |||
for (int i = 0; i < count; i++) { | |||
Card card = opponent.getLibrary().removeFromTop(game); | |||
Card card = opponent.getLibrary().getFromTop(game); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And don’t forget to add cards removing in code like that here. Maybe it’s better to keep removeFromXXX methods.
Yeah, if it's not a draw, then it shouldn't be flagging empty library for game loss. But some devs in the past occasionally choose wrong method. Cellar Door is the one I fixed here.
I don't see the problem? CardsImpl won't add null
Yeah, after further consideration, I'm inclined to agree. I don't like that the code requires it, but for now, best to make minimal changes on that front. |
PlayerImpl::drawCards