You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Following #73 (and cleanup PR #116), some questions came up in the final review:
function_events_invited:
shouldn't blocking be based on the event author instead of the contact author?
function_invitation_claim_array:
how could _invitation_ids be null?
where is append_invitation_array(result_invitation_ids, _invitation_id) defined? ✅
is the function stable still?
function_invitation_contact_ids:
is the NULL check necessary for blocking? (currently line 24)
is the blocking check even necessary here as invitation_claim_array and events_organized already account for blocking?
table_account_block:
can you block yourself?
why did I comment to remove the delete mutation on the table?
i'd say the select policy should only allow entries that were created by the invoker, not the ones that target the invoker. It's common in social networks to not definitely know "who blocked me" but only see no data (e.g. empty profiles) of people who blocked the invoker.
table_account_block_policy:
why are selections allowed for anonymous users?
is maevsi.invoker_account_id() IS NOT NULL necessary here and in other files?
table_event_category_mapping_policy:
does the selection based on visibility make sense?
table_invitation_policy:
does the select filter for blocking on own events make sense?
sqitch.plan:
could the tests be placed in a way that does not require a test schema? (more of a challenge for myself)
all:
should we extract the common UNION selection on the account_block table into a function? ✅
Let's talk about these questions in person @sthelemann
The text was updated successfully, but these errors were encountered:
Following #73 (and cleanup PR #116), some questions came up in the final review:
function_events_invited
:function_invitation_claim_array
:_invitation_ids
be null?append_invitation_array(result_invitation_ids, _invitation_id)
defined? ✅function_invitation_contact_ids
:NULL
check necessary for blocking? (currently line 24)invitation_claim_array
andevents_organized
already account for blocking?table_account_block
:table_account_block_policy
:maevsi.invoker_account_id() IS NOT NULL
necessary here and in other files?table_event_category_mapping_policy
:visibility
make sense?table_invitation_policy
:select
filter for blocking on own events make sense?sqitch.plan
:all:
UNION
selection on theaccount_block
table into a function? ✅Let's talk about these questions in person @sthelemann
The text was updated successfully, but these errors were encountered: