Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close is not channel if err on the reader #7

Open
segator opened this issue Jun 1, 2020 · 0 comments
Open

Close is not channel if err on the reader #7

segator opened this issue Jun 1, 2020 · 0 comments

Comments

@segator
Copy link

segator commented Jun 1, 2020

https://github.com/machinebox/progress/blob/master/progress.go#L117-L142

you should do something like if counter.Err()!=nil { return } this will force the clannel be closed with your defered close(ch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant