Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown issue #3

Open
4 tasks done
maboroshin opened this issue Feb 27, 2020 · 8 comments
Open
4 tasks done

Unknown issue #3

maboroshin opened this issue Feb 27, 2020 · 8 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@maboroshin
Copy link
Owner

maboroshin commented Feb 27, 2020

Unknown issue with dark theme. Probably need to improve the program, not only the theme.

Let me know if you find a solution.

Unsolved color

Corrected on ver 4.5.0

Corrected on ver 4.3.0

Corrected on ver 4.2.2


Sample references

@maboroshin maboroshin added the enhancement New feature or request label Feb 27, 2020
@maboroshin maboroshin self-assigned this Feb 27, 2020
@maboroshin
Copy link
Owner Author

maboroshin commented Feb 27, 2020

  • Link text color (blue) is not visible** in Option and About. Also RSS reader, Update dialog.

If it is changed to Upload text color, it will visible in both dark and white. Visible in many situations without writing a new QSS (similer CSS).

Its value is : #3299ff (50, 153, 255) from src/gui/properties/speedplotview.cpp
link7

HTML RGB (setText, setHtml)
src/gui/aboutdialog.cpp
link1

aboutdialog.ui ? (QLabel a href)
link2

src/gui/thanks.html /
src/gui/gpl.html (HTML via aboutdialog.cpp)
link3

src/gui/optionsdialog.ui ? (QLabel a href)
link4

same
link5

src/gui/advancedsettings.cpp used makeLink (Qlabel a href)
link6

src/gui/mainwindow.cpp (QString a href)
qbqa

src/gui/rss/rsswidget.cpp (QString)
RSS reader. (No image)

@maboroshin
Copy link
Owner Author

maboroshin commented Feb 27, 2020

  • Log text color seems to have the same problem as Transfer list.

But easy to do. It should change blue to #3299ff. On many darks, this initial value #3299ff will remain visible.

Convert the Log widget to use custom View/Model #12144 of Pull requests in official qBittorrent, in progress.

HTML RGB (QString font color=)
src/gui/executionlogwidget.cpp
log

@maboroshin
Copy link
Owner Author

maboroshin commented Feb 27, 2020

  • Progress/Availability color is not dark. (White and blue)

This code is: #5 (comment)

But easy to do. It should change white to gray, e.g. #c0c0c0 (Qt::lightGray). The contrast is reduced.

Internal RGB: Qt::white, QT::blue

src/gui/properties/piecesbar.cpp

src/gui/properties/downloadedpiecesbar.cpp / pieceavailabilitybar.cpp
Availability

@maboroshin
Copy link
Owner Author

maboroshin commented Feb 27, 2020

Margin and text color with right-click on the transfer list.

Green: transferlistwidget.cpp - tristateaction.cpp - tristatewidget.cpp
I don't know the element name. Changes are possible but partial. The background color is changed, but text color and the margin remains.
qbContext2

Images by adem4ik.

image
image

Different font than the default.

@maboroshin
Copy link
Owner Author

maboroshin commented Feb 27, 2020

Crrected: Cannot be separated by CSS (QSS). I am trying. When I narrow down here, others narrow down and become invisible.

  • Orage: (On ver 4.2.2, Orange issue only corrected)
    Selector is the same as right-clicking on a column.
  • QTabWidget QStackedWidget QTreeView QMenu::item

And There are can't used.

  • QTabWidget QStackedWidget QHeaderView QMenu::item
  • QTabWidget QStackedWidget QHeaderView QTreeView QMenu::item
  • QTabWidget QStackedWidget QTreeView QHeaderView QMenu::item

Thus, they cannot be distinguished.

qtList2

Same problem as orange. Tool button context menu. Making this check visible will make other margins wider.

  • Yellow : (On ver 4.2.2, Yellow issue corrected)
    Common selector:
  • QMenu::item

There are can't used.

  • QToolBar QMenu::item

qbtool

@maboroshin maboroshin pinned this issue Mar 29, 2020
@charmesal

This comment has been minimized.

@maboroshin maboroshin added the documentation Improvements or additions to documentation label Jan 1, 2021
@maboroshin
Copy link
Owner Author

maboroshin commented Jan 3, 2021

  • Icons: Error, Warning

Can't change.

image

@b-user

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants