Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyword argument before variable positional arguments list in the definition of view_or_basicauth function #7

Open
jamercee opened this issue Aug 12, 2018 · 0 comments

Comments

@jamercee
Copy link

The function view_or_basicauth() has a bug. realm cannot be declared as a keyword before the variable *args. I believe the simple solution is to drop the assignment, otherwise you need to re-write to two callers ie: logged_in_or_basicauth and has_perm_or_basicauth. Removing the assignment seems like a safe action as both of the callers provide a default value.

Suggested signature:

def view_or_basicauth(view, request, test_func, realm, *args, **kwargs):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant