Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verification of hpc and leaphub data #25

Open
suryadheeshjith opened this issue Feb 13, 2024 · 3 comments
Open

Verification of hpc and leaphub data #25

suryadheeshjith opened this issue Feb 13, 2024 · 3 comments
Assignees

Comments

@suryadheeshjith
Copy link
Collaborator

suryadheeshjith commented Feb 13, 2024

For the notebook OM4_SST_Bias here,

Need to ensure the data coming from these sources:

ds_ZB = xr.open_mfdataset('/vast/pp2681/ZB2020/ocean_monthly/*', decode_times=False).isel(time=slice(276,636)) # time slice corresponds to 1981-2010
ds_om4 = xr.open_mfdataset('/vast/pp2681/unparameterized/annual/5yr/*').isel(time=slice(23,48))
om4T = ds_om4.thetao.isel(z_l=0).mean('time').compute()
ZBT = ((ds_ZB.average_DT*ds_ZB.thetao.isel(z_l=0)).sum('time') / ds_ZB.average_DT.sum('time')).compute()

matches,

path = "gs://leap-persistent/jbusecke/OM4_m2lines/daily_combined.zarr"
ds = xr.open_dataset(path, engine="zarr", chunks={})
ds_ZB = ds.sel(experiment="ZB2020")
ds_om4 = ds.sel(experiment="unparameterized")
ZBT = ds_ZB["tos"]
om4T = ds_om4["tos"]
@suryadheeshjith
Copy link
Collaborator Author

@jbusecke Looking at the datasets more closely, the timelines of the obs datasets do not match. 'https://ncsa.osn.xsede.org/Pangeo/pangeo-forge/WOA_1degree_monthly-feedstock/woa18-1deg-monthly.zarr' has 1958 monthly data while '/vast/pp2681/WOA/woa_1981_2010.nc' presumably has data between 1981 and 2010. These two lines of code probably confirms this -

ds_ZB = xr.open_mfdataset('/vast/pp2681/ZB2020/ocean_monthly/*', decode_times=False).isel(time=slice(276,636)) # time slice corresponds to 1981-2010
ds_om4 = xr.open_mfdataset('/vast/pp2681/unparameterized/annual/5yr/*').isel(time=slice(23,48))

Furthermore, The saved data 'gs://leap-persistent/jbusecke/OM4_m2lines/daily_combined.zarr' which contains ZB2020 and the unparameterized results have data only between 2008 and 2012.

@suryadheeshjith suryadheeshjith self-assigned this Feb 15, 2024
@jbusecke
Copy link
Collaborator

Ok the real issue here is that we do not know (or maybe somebody does?) where /vast/pp2681/ZB2020/ocean_monthly/* is coming from (this is one of the major motivations to build datasets in a reproducible way!).
Does that data have some metadata so we can confirm the version? I suspect this is an earlier version of world ocean atlas, but we need to confirm this before moving on.

Furthermore, The saved data 'gs://leap-persistent/jbusecke/OM4_m2lines/daily_combined.zarr' which contains ZB2020 and the unparameterized results have data only between 2008 and 2012.

This was the data I had available at the time. I think as long as we make sure that we are computing the mean on the same time frame for both we should be ok? Referring to @LaureZanna for final comment on this.

@suryadheeshjith
Copy link
Collaborator Author

I believe they are data coming from different time frames.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants