Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make node parsing and formatting ipv6-friendly #939

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

make node parsing and formatting ipv6-friendly #939

wants to merge 1 commit into from

Conversation

retrnull
Copy link

There are two things that make using IPv6 nodes impossible:

  • The formatting of the node address when passing it to monero, which does not include square brackets when the port is included
  • The parsing of the node, which rejects IPv6 addresses because of the number of colons.

This patch fixes both issues by using the Guava library to parse and format addresses.
Fixes #922

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ipv6 nodes not supported (1.7XMR)
1 participant
@retrnull