Malformed string literal for tag attribute

[rmarronnier]

From luckyframework/lucky#1823 :

When using the https://luckyframework.org/html tool to convert
<div hx-get="/example" hx-headers='{"myHeader": "My Value"}'>Get Some HTML, Including A Custom Header in the Request</div> to lucky html, we get invalid code :

div "Get Some HTML, Including A Custom Header in the Request", hx_get: "/example", hx_headers: "{"myHeader": "My Value"}"

This results in a compile error :

Error: unexpected token: "myHeader"

[matthewmcgarvey]

The source of the problem is here

website/vendor/html2lucky/tags/tag.cr

Lines 79 to 81 in 991937d

	private def wrap_quotes(string : String) : String
	QUOTE + string.gsub("\"", "\\\"") + QUOTE
	end

[rmarronnier]

Thanks for the tip : why the vendor subfolder ? Should I open a PR with a fix in this repo ? Or should it be fixed in this archived repo : https://github.com/luckyframework/html2lucky ?

[jwoertink]

The archived repo isn't used anymore. It's just what's in vendor now to keep the whole codebase together. I just use vendor as a common pattern in my projects where I have libraries that could be external, but I just wrap them up internally instead.