Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename dont_report in Error actions #1820

Open
jwoertink opened this issue Aug 12, 2023 · 1 comment
Open

Rename dont_report in Error actions #1820

jwoertink opened this issue Aug 12, 2023 · 1 comment

Comments

@jwoertink
Copy link
Member

No one has actually brought this up, but I would imagine that since this is an English contraction missing the punctuation, it may be a little confusing for non-english speakers. I think we can just call it ignore_report or skip_report or something like that...

To avoid a breaking change, we can add whatever the new method name is, then deprecate the old one.

@mdwagner
Copy link
Contributor

I like skip_report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants