Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] [ESP3D v3] Hide notifications #973

Closed
dbuezas opened this issue Dec 3, 2023 · 6 comments
Closed

[Question] [ESP3D v3] Hide notifications #973

dbuezas opened this issue Dec 3, 2023 · 6 comments

Comments

@dbuezas
Copy link

dbuezas commented Dec 3, 2023

Is there any way to not display these notifications?

image

It seems like these aren't hidden if the tab is not in the foreground for a while so they also accumulate.

@luc-github
Copy link
Owner

they should hide after a while
but I think they are meaningless they should not be send if they are using HOMEASSITANT I think
same for display:
Check here :
https://github.com/luc-github/ESP3D/blob/3.0/esp3d/src/modules/notifications/notifications_service.cpp#L188-L196

@dbuezas
Copy link
Author

dbuezas commented Dec 3, 2023

It looks like there is a bug on top of that. If I leave the tab in the background they accumulate and only the last one is removed:
image

@luc-github
Copy link
Owner

what do you mean by tab in background ?

@dbuezas
Copy link
Author

dbuezas commented Dec 3, 2023

For example if you have 2 tabs open in your browser, one is ESP3D and the other is youtube, but you are watching youtube so the ESP3d is "in the background", or inactive

@dbuezas
Copy link
Author

dbuezas commented Dec 3, 2023

I opened a PR luc-github/ESP3D-WEBUI#375

@dbuezas dbuezas closed this as completed Dec 3, 2023
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants