Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST]Improve usage of ISO-8601 date format #369

Closed
luc-github opened this issue Oct 10, 2023 · 4 comments
Closed

[FEATURE REQUEST]Improve usage of ISO-8601 date format #369

luc-github opened this issue Oct 10, 2023 · 4 comments

Comments

@luc-github
Copy link
Owner

luc-github commented Oct 10, 2023

Linked to luc-github/ESP3D#935
1 - when setting date by [ESP800] command, use +/-XX:XX additional info (optionnally ) to set the time zone also
2 - add optionnal parameter in post which would be the date/time in same format (2023-10-10T11:08:47+08:00)
and the last modified date/time of the file using file.lastModified; API

@luc-github
Copy link
Owner Author

The time zone is an optional parameter in web ui now tz=+/-HH:MM
The SD is fat32 which store only local time not UTC so current format is ok
(2023-10-10 11:08:47)
That said I will add support of 2023-10-10T11:08:47+08:00 and 2023-10-10T11:08:47.000+08:00 format in webUI /files and /sdfiles responses JSON, to make porting easier on coming FW

The upload will also have a last modification date as post parameter which could be used to update file timestamp on ESP that does not have time sync enabled

@luc-github
Copy link
Owner Author

luc-github commented Oct 14, 2023

Additionnaly there is no DST support for the moment - because it need to access to a database that won't fit to flash.

One solution would be to detect time difference between browser time supplied by ESP800 and time set and if time is different by 1h propose to user to update time on esp board, it is one possible solution =>TBD

Any suggestion // other idea is welcome

@luc-github
Copy link
Owner Author

done I think

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant