Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Psychec's CI to use C++17 #41

Open
aytey opened this issue Mar 22, 2021 · 1 comment
Open

Update Psychec's CI to use C++17 #41

aytey opened this issue Mar 22, 2021 · 1 comment

Comments

@aytey
Copy link
Contributor

aytey commented Mar 22, 2021

Is your feature request related to a problem? Please describe.

PR #40 "fell over" because it used the legally-allowed C++17 header filesystem, but this does not actually exist in psychec CI base image:

Describe the solution you'd like

Update the GitHub actions to use a more-modern Ubuntu or look at using a later GCC within 18.04

Describe alternatives you've considered

Change PR #40 to not use filesystem (even though it is in C++17 😞)

Additional context

Build log from #40: https://github.com/ltcmelo/psychec/pull/40/checks?check_run_id=2161399189#step:4:65

@ltcmelo
Copy link
Owner

ltcmelo commented Mar 22, 2021

I didn't know about such ubuntu "situation"… it appears that it needs <experimental/filesystem> (with extra link flags). But I think this can be handled in the Cmake file and with a preprocessing directive to choose between <filesystem> and <experimental/filesystem> ?

(Added further comments in the PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants