Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curve Type of Key inside Mainline is not Loaded #29

Open
SadaleNet opened this issue Dec 24, 2015 · 2 comments
Open

Curve Type of Key inside Mainline is not Loaded #29

SadaleNet opened this issue Dec 24, 2015 · 2 comments
Labels

Comments

@SadaleNet
Copy link

curveType is only loaded when the <key> is inside <timeline>.

When curveType is inside <mainline>, it isn't loaded. EDIT: and the curveType follows the one specified in <key> inside <timeline>.

Version of runtime: haxelib

EDIT: interestingly, curveType of MainlineKey isn't specified in the scml reference. But the editor is generating mainline key with curveType as of R5. And the behavior of the editor is that the curveType of MainlineKey overrides TimelineKey. Maybe time to ask the guys in BrashMonkey for explanation?

EDIT: I've checked their C++ reference implementation. Their MainlineKey has a TimeInfo, which has an EasingCurveInterface. Their EasingCurveInterface is inherited by implementation of curve, such as InstantEasingCurve and CubicEasingCurve. Therefore, their MainlineKey is indeed capable for storing curveType. Maybe their scml documentation is outdated?

@loudoweb
Copy link
Owner

loudoweb commented Feb 1, 2016

Thank you for the details. I'll check this with Brashmonkey's if they can help on the best way to implement this.

@loudoweb
Copy link
Owner

loudoweb commented Feb 1, 2016

I think I can implement this by only modifying the parsing on MainlineKey without doing anything else in the engine. I'm just waiting for some details from Brashmonkey's to avoid any mistakes.

@loudoweb loudoweb added the bug label Feb 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants