How to clean up if a an action fails?

[AlejandroAkbal]

I've recreated the steps defined here:
https://laravel.com/docs/9.x/queues#cleaning-up-after-failed-jobs

But the failed method does not seem to be triggered when an exception is thrown

[Wulfheart]

Do you have a reproduction repository?

[AlejandroAkbal]

No, sorry

I'm not near a computer right now, but a simple action that throws an exception and has a "failed" public method as per the jobs docs should suffice

[lorisleiva]

You're pointing to the Laravel documentation of a job which differs from an Action being run as a Job.

An Action as defined by this package is not a Job as defined by Laravel. Please see https://laravelactions.com/2.x/how-does-it-work.html#decorating-your-actions.

The failed hook is not currently supported. Please see AsJob references here: https://laravelactions.com/2.x/as-job.html.

[AlejandroAkbal]

So no way to clean up after jobs then, right?

[AlejandroAkbal]

I'll be wrapping everything in a try-catch then

[jameswagoner]

I am actually doing something similar to a clean up and works well.

Just type hint JobDecorator in your asJob() method. Then you can add jobFailed() method to cleanup.

public function handle(Team $team, bool $fullReport = false): void
{
    // Prepare report and send it to all $team->users.
}

public function asJob(JobDecorator $job, Team $team)
{
    if ($team->someCondition) {
        $job->fail('Some condition failed this job');

        return;
    }

    $this->handle($team, true);
}

public function jobFailed(Throwable $e): void
{
    // Cleanup
}