Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential issue regarding ABI identification for PyPI manylinux purposes #63

Open
xen0n opened this issue Aug 6, 2024 · 3 comments
Open

Comments

@xen0n
Copy link
Member

xen0n commented Aug 6, 2024

Link: pypa/manylinux#1587

If we were to support LoongArch manylinux wheels on PyPI, we must be able to prevent installation of wheels built on a different world than that of the running system.

Right now, due to:

the multiarch specifiers for both worlds are the same, so we must be able to distinguish by other means. This is likely glibc symbol versions for glibc-based systems, but I think musl-based systems will need something else.

@xen0n
Copy link
Member Author

xen0n commented Aug 6, 2024

cc @yzewei @loongson-zn (seems both are from Loongson)

@xry111
Copy link
Member

xry111 commented Aug 6, 2024

Maybe just check EF_LOONGARCH_OBJABI_V1 for every EM_LOONGARCH ELF files containing a SEC_LOAD | SEC_CODE | SEC_HAS_CONTENTS section in the wheel.

@xry111
Copy link
Member

xry111 commented Aug 6, 2024

Or, we can add this check into libc loader (gated with something like a Glibc tunable) and the packages requiring such a check will be able to simply enable it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants