Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't make a link with a URL longer than 75 chars #181

Open
durka opened this issue Jun 30, 2015 · 2 comments
Open

can't make a link with a URL longer than 75 chars #181

durka opened this issue Jun 30, 2015 · 2 comments
Labels

Comments

@durka
Copy link
Member

durka commented Jun 30, 2015

As seen here. The word wrapping happens when the comment is posted, but the wiki formatting pass is later (during display), so links with long URLs have random <br/>s inserted in them.

@durka
Copy link
Member Author

durka commented Jun 30, 2015

IMO, the real bug is hard wrapping the text at post time. That's a 100% display decision and we can do it HTML/CSS on the comment pages. This would be done by:

  1. Add a class="pinka" attribute to the <p> tags that contain comments.
  2. Add a style rule p.pinka { width: 75ch; word-wrap: break-word } to the page.

@tsani
Copy link

tsani commented Jul 4, 2015

Yeah, hard-wrapping the text is a bad decision IMO. Plus, you get to avoid storing HTML in the backend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants