Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Add notice that ecs compatibility is required for data streams #1174

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

karenzone
Copy link
Contributor

Fixes: #1167

@karenzone karenzone self-assigned this Mar 20, 2024
@karenzone karenzone requested a review from yaauie March 20, 2024 00:21
@karenzone
Copy link
Contributor Author

@yaauie, please see if I messaged this to your liking

@karenzone
Copy link
Contributor Author

Update: We're going deeper to be sure we've identified any additional complexities.

Copy link
Contributor

@yaauie yaauie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are correct as-is.

I have opened #1176 to track our ability to change the behaviour in a way that would allow data streams to be used in combination with ecs being disabled.

@karenzone karenzone merged commit bc3f2fa into logstash-plugins:main Mar 22, 2024
2 checks passed
@karenzone karenzone deleted the 1167-ecs-datastreams branch March 22, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc: Update data streams info to explain implications of ECS settings
3 participants