Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement lowering of torch.aten.cosh to linalg. #2631

Closed
godot73 opened this issue Dec 12, 2023 · 6 comments
Closed

Implement lowering of torch.aten.cosh to linalg. #2631

godot73 opened this issue Dec 12, 2023 · 6 comments
Assignees
@godot73 @frederik-h @AmosLewis @vivekkhandelwal1

Comments

@godot73
Copy link
Collaborator

godot73 commented Dec 12, 2023

torch.aten.cosh is in the op-to-implement list.
@godot73
Copy link
Collaborator Author

godot73 commented Dec 12, 2023

@vivekkhandelwal1 @frederik-h

@vivekkhandelwal1
Copy link
Collaborator

@vivekkhandelwal1 @frederik-h

Hi @godot73, I didn't understand your comment.

@frederik-h
Copy link
Contributor

@vivekkhandelwal1 @frederik-h

Hi @godot73, I didn't understand your comment.

I assume @godot73 just wanted to bring this issue to our attention.
@godot73 I would assume that the implementation of this operator should be pretty similar to what I did here #2614.

@godot73 godot73 self-assigned this Dec 12, 2023
@godot73 godot73 pinned this issue Dec 12, 2023
@godot73 godot73 unpinned this issue Dec 12, 2023
@godot73 godot73 pinned this issue Dec 12, 2023
@godot73 godot73 mentioned this issue Dec 12, 2023
Merged
@godot73
Copy link
Collaborator Author

godot73 commented Dec 13, 2023

Merged llvm/llvm-project#75153 at llvm/llvm-project.

@godot73 godot73 mentioned this issue Dec 14, 2023
Merged
@godot73
Copy link
Collaborator Author

godot73 commented Dec 14, 2023

Merged #2645

@godot73
Copy link
Collaborator Author

godot73 commented Dec 15, 2023

Merged the lowering implementation: #2635

@godot73 godot73 closed this as completed Dec 15, 2023
@godot73 godot73 unpinned this issue Dec 15, 2023
@godot73 godot73 mentioned this issue Jan 3, 2024
Open
@frederik-h frederik-h mentioned this issue Jan 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@godot73 godot73

@frederik-h frederik-h

@AmosLewis AmosLewis

@vivekkhandelwal1 vivekkhandelwal1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@godot73 @frederik-h @AmosLewis @vivekkhandelwal1