[FIRRTL][ModuleInliner] Should respect the NLAs when deciding to inline instances.

[youngar]

The inliner is inlining all instances of a module with a non-local InlineAnnotation, irrespective of the current path. I opened a similar issue for the Scala FIRRTL compiler here: chipsalliance/firrtl#2498

  firrtl.nla @nla [#hw.innerNameRef<@Top::@foo>, @Foo]
  firrtl.module @Foo() attributes {annotations = [{circt.nonlocal = @nla, class = "firrtl.passes.InlineAnnotation"}]} {
    %f = firrtl.wire  : !firrtl.uint<1>
  }
  firrtl.module @Top() {
    firrtl.instance foo sym @foo  {annotations = [{circt.nonlocal = @nla, class = "circt.nonlocal"}]} @Foo()
    firrtl.instance bar  @Foo()
  }

circt-opt --pass-pipeline='firrtl.circuit(firrtl-inliner)' inline.mlir produces:

  firrtl.circuit "Top"  {
    firrtl.module @Top() {
      %foo_f = firrtl.wire  : !firrtl.uint<1>
      %bar_f = firrtl.wire  : !firrtl.uint<1>
    }
  }

[youngar]

I see that Chisel adds NoDedupAnnotation when using InlineInstance, so it might make sense to just close this issue. I'm curious if I can safely fix this in the CIRCT compiler or if it's possible someone is relying on this behaviour and its "working as intended"