Support for japanese

[jonatan-alama]

It seems like chinese font is being set right now, which breaks japanese text.

It would be nice if the viz used the system most appropiate font by not setting any font family, or being able to select or override the font family.

[thomasbanghart]

Hey @jonatan-alama thanks for flagging this and sorry for the delay on getting back to you!

If you have the opportunity, could you upload a photo of this behavior? Are Japanese characters ending up as blank spaces or are they being replaced with the wrong character altogether?

In the meantime are you able to clone this repo, make the necessary changes, and use that build? Thanks again and we'll take a look into changing the font-family declaration.

[jonatan-alama]

Thanks @thomasbanghart for the reply.

Chinese and Japanese share many characters, but some differ slightly in the writing.

Here is an example for one character, using the font that is now set in the report table (Noto Sans TC, Noto Sans SC) and using the same font with the JP variant:

Noto Sans TC
https://fonts.google.com/specimen/Noto+Sans+TC?preview.text=%E7%9B%B4&preview.text_type=custom

Noto Sans SC
https://fonts.google.com/specimen/Noto+Sans+SC?preview.text=%E7%9B%B4&preview.text_type=custom

Noto Sans JP
https://fonts.google.com/specimen/Noto+Sans+JP?preview.text=%E7%9B%B4&preview.text_type=custom

Thanks for your advice, I was already using a fork with the default font removed:
jonatan-alama@4ea7b37

This fixes it for us because it uses the system font.

I guess the current font selection exists because of some previous problem with showing Chinese characters. I don't mind making a fix and PR if we can agree in a way of fixing it that doesn't break Chinese again.