Empty history list (buffer list, etc.) on Windows #967
Labels
Comments
|
Are the version of the repo and binaries aligned? I mean switching to a specific tag of vim-clap repo and use the binary built for that tag, It's possible the binary is not compatible with the code on the client(Vim) side. BTW, does the other providers work or just this particular provider? |
|
Thanks for your quick reply :-) I have used the maple.exe corresponding to the tag in my tests but it didn't help I believe it is all the providers but I only tested
Reamrk: It seems that maple.exe is somehow backward compatible the 0.43 version works with 0.37 tag Is there a test I can do to narrow down the problem? |
|
I just published a new release v0.44, I don't have a Windows machine, can you try that and see how it goes? To debug it further, create a |
|
Thanks for your message and your release. But I don't find the |
|
|
|
I have tried several syntax but with no luck. If you have pointers I'm interested :-) |
|
I have compiled locally a version of |
|
Hmm, interesting, that means the one built by GitHub Action maple-x86_64-pc-windows-msvc does not work? Can you try that binary from the cmd, just to check whether it works, something like |
|
It does do something. Here is the result of: Here is the result of: |
|
I don't manage to make the logging functionality working. I have tried the specify the config file explicitly Here is my |
|
Try |
|
If I specify the log file explicitly like proposed it works. I have to double the backslash But If I don't specify the config file it seems the config file is not found. |
|
The two logs are very similar but the log produced by the exe from GitHub has an addition |
|
The whitespace in path shouldn't be an issue, it's fine from the example in the library used in vim-clap https://docs.rs/directories/latest/directories/struct.ProjectDirs.html#examples, https://github.com/liuchengxu/vim-clap/blob/master/crates/maple_core/src/dirs.rs#L9. So now the locally compiled version works fine for you, but the one on GitHub does not, right? |
|
Indeed. |
|
That's expected, the log is not enabled until you explicitly specify it. Not a Windows expert, I have no idea what happened exactly. |
|
It seems to me that the configuration is not found automatically. It looks that the default place I tried is wrong. I'll try to debug to tell you more. If you tell me how to test the maple in rpc mode I can give you more hint about what is not working with the GitHub version. Do you have a Python client and a set of json file to test? |
|
Basically, the maple is started in RPC mode as long as you start vim, so when you enter vim, try |
|
Any way to specify the log file is using an env variable, try setting |
|
The |
|
I have add some trace to the maple executable and it seems that configuration file used by maple is actually: |
|
Hmm, interesting, thanks for letting me know, I'm only sure about the location of macOS and Linux honestly. |
|
Here are the files that you requested: This is the log file generated by the executable from GitHub: This is the log file generated by the executable that I have compiled from the source: Like already mentioned in the log generated by the executable from GitHub the method have an additional parameter |
|
Yeah, that's the culprit. I downloaded the v0.44 for macOS which works fine. You can add a debugging print to see the message sent to Rust backend that whether the diff --git a/autoload/clap/job/daemon.vim b/autoload/clap/job/daemon.vim
index f28bcd7..fbcb174 100644
--- a/autoload/clap/job/daemon.vim
+++ b/autoload/clap/job/daemon.vim
@@ -118,6 +118,7 @@ else
endfunction
function! clap#job#daemon#send_message(msg) abort
+ echom 'Sending:'.string(a:msg)
call ch_sendraw(s:job, a:msg."\n")
endfunction
endifI do plan to remove it from the notification and it's done in another branch, but it makes no sense as the branch is not yet merged and vim-clap/autoload/clap/client.vim Line 48 in 6bd58c0 |
|
Here are the logs created when I add the |
|
Don't see anything wrong, perhaps add some log on the Rust side to see what messages are invalid. Apply the following path, recompile, start Vim and type some query, check out the log. diff --git a/crates/maple_core/src/stdio_server/mod.rs b/crates/maple_core/src/stdio_server/mod.rs
index 734d8ae..85caa0f 100644
--- a/crates/maple_core/src/stdio_server/mod.rs
+++ b/crates/maple_core/src/stdio_server/mod.rs
@@ -178,6 +178,7 @@ impl Client {
/// Actually process a Vim notification message.
async fn do_process_notification(&self, notification: Notification) -> Result<()> {
+ tracing::trace!(?notification, "new notification");
let provider_session_id = || {
notification
.session_id |
|
Here is the corresponding log file: |
|
I see, we can't patch the executable that produced error logs. The clap-tracing.log you just uploaded contains no error messages, it should just work fine. I don't know what we can do here right now. Perhaps just wait for next release to see that will work for you. |
|
Thanks for your support and thanks for vim-clap that is the best on Vim+Windows :-) |
|
Had the same issue and it's well the binary distribution which is wrong in some way. Installing rust tools and compiling it locally fixed the issue. P.S.: First try of this plugin that I discovered on hackingcpp.com and I'm removing fzf plugin now and changing all my custom map and cabbrev to use it, it's really damn fast |
|
https://github.com/liuchengxu/vim-clap/releases/tag/v0.45 New release is out, let me know if it still does not work. |
|
I get an error when I try to update with
But If I download the version of |
|
Looks like there is an issue of downloading the binary on Windows vim-clap/crates/upgrade/src/lib.rs Line 125 in 710c0dc Unfortunately, I don't have a Windows machine to test it, have to wait for someone to fix it 🙃 . |
|
If I run the command
|
|
What looks odd if that if I remove the The impression I have is that:
|
|
My mistake the plugin didn't update correctly because of some local change I did for debugging the previous version. Now vim-clap download the correct version 0.45 (the problem was in Everything seems right to me now :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Instructions: Replace the template text and remove irrelevant text (including this line)
Warning: if you don't fill this issue template and provide the reproducible steps the issue could be closed directly.
Environment (please complete the following information):
Describe the bug
A clear and concise description of what the bug is.
I get an empty history list.
If I try the commit before (fdf8d6c) the version is still running smooth.
I have also tried several version 0.39, 0.40, 0.41, 0.42, 043 but I have the same symptoms.
The text was updated successfully, but these errors were encountered: