Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check simplified generic_sdr PHY / Apply changes to generic_ddr PHY. #58

Open
enjoy-digital opened this issue Sep 8, 2021 · 2 comments

Comments

@enjoy-digital
Copy link
Member

Hi @pawelsag, @piotr-binkowski,

I did some simplifications to to the generic_sdr PHY and tested it on the iCEBreaker/Arty boards while doing these changes. Could you check that it's still also working correctly on your boards?

I tried to commit each simplification step, could you try to also apply similar silmplifications to the generic_ddr PHY?

Thanks,

Florent

@enjoy-digital
Copy link
Member Author

enjoy-digital commented Sep 20, 2021

@piotr-binkowski: I stared some simplifications on top of #59:

I was testing on the Arty while doing the changes, can you verify it's also working fine on your side (CrossLink-NX)?

@enjoy-digital
Copy link
Member Author

I just did other simplifications on top of this:

Theses changes should not changed the behavior but it would be nice to have feedback on the Crosslink NX. I also think we can simplify LiteSPIDDRPHYCore by changing the clk polarity as done in #60 and validated on Arty (for reads). Can you check @piotr-binkowski, @kgugala and merge if working on your config?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant