Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resource warnings #3838

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: resource warnings #3838

wants to merge 4 commits into from

Conversation

gsakkis
Copy link
Contributor

@gsakkis gsakkis commented Oct 22, 2024

Description

  • Fix ResourceWarning from unclosed UploadFile instances
  • Fix ResourceWarning in run_server fixture
  • Report all warnings as errors unless explicitly silenced

Closes #3835

@gsakkis gsakkis requested review from a team as code owners October 22, 2024 06:37
@gsakkis gsakkis changed the title Fix: resource warnings fix: resource warnings Oct 22, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.42%. Comparing base (dcae3b3) to head (af78e6c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
litestar/datastructures/upload_file.py 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3838      +/-   ##
==========================================
- Coverage   98.42%   98.42%   -0.01%     
==========================================
  Files         333      333              
  Lines       15348    15350       +2     
  Branches     1694     1694              
==========================================
+ Hits        15107    15108       +1     
- Misses        111      112       +1     
  Partials      130      130

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cofin
cofin approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@cofin cofin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3838

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cofin cofin cofin approved these changes

Assignees
No one assigned
Labels
area/connection area/datastructures area/dependencies This PR involves changes to the dependencies pr/external pr/internal size: small Triage Required 🏥 This requires triage type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: ResourceWarning: Unclosed file <tempfile.SpooledTemporaryFile object ...>
2 participants
@gsakkis @cofin