-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New backend #49
Comments
great 💯 ! nice work! i am looking forward to integrate that!!!
There are some minor style things I'd like to keep homogenous. |
Checkout #50
OK. But in your code has problem when you start several servers in one process. But it rare.
I need only server without wss. But if for wss needs only TLS connection and because it quite easy do I implement this one for client moteus/lua-lluv-websocket@9d8767d that works with `"wss://echo.websocket.org".
I will be very appreciate because I never use busted. |
i'll extend busted to support lluv. |
making progress on that. local trace
local ok, err = suite.loop.xpcall(
function()
this_test.f(wrap_done(done))
end,
function(err)
trace = debug.traceback("", 2)
-- trace is nil using lluv !!!
return err
end) |
added a workaround ... as long as you dont want lluv officially supported by busted, no prob for me. git clone https://github.com/lipp/busted/tree/1.11.1-uvll-support
cd 1.11.1-uvll-support
./try this will install busted with lluv support. The test should prob look pretty much the ev_client/ev_server tests. You must call |
I decide to release my version. I decide copy some files from your repo (because I make some changes to them and also because there no rockspec only for core and I do not add deps from all other lua-websockets deps like You may be interested with my bit.lua file. It implement
|
great! thanks for keeping me updated! The bit stuff for lua 5.3 could be very interesting for soon. sorry I wasnt so focused on lua-websockets lately. Unfortunately time is running very short with kids :) . |
I just imlement new backend for lua-websocket based on my libuv binding.
For now it implement same API as
ev
backend.And I have several question:
1 To be avaliable you need add optional require to client/server files in main repo? (I have no objection to just merge my reto to this repo)
2 No all Linstners share same client set (
clients
table). Is it intentional or better if each server will have its own set?3 To support
wss
protocol is it enough just make TLS connection?The text was updated successfully, but these errors were encountered: