Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Some plugins do not work due to the use of symlinks for plugin directory #70

Closed
1 task done
armanddidierjean opened this issue Nov 11, 2023 · 11 comments
Closed
1 task done

Comments

@armanddidierjean
Copy link

armanddidierjean commented Nov 11, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Hello,

I'm trying to use this docker image with the plugin OpenID Connect.
It works with the image lscr.io/linuxserver/piwigo:13.1.0, but starting with lscr.io/linuxserver/piwigo:13.2.0 the plugin does not work :
When I open http://localhost:8080/plugins/OpenIdConnect/auth.php I get an internal error (code 500) instead of being redirected to the auth provider.

The image 13.2.0 correspond, I think, to the addition of the symbolic link /app/www/public/plugins -> /config/www/plugins. I believe this is because some modules define relative path, like here auth.php#L18 which doesn't points to the right directory when symbolic links are used.

There is also an issue in Piwigo repository which does not seem up-to-date but which mention incompatibility between symbolic links and some plugins: Piwigo#907

When I remove the symlink, be deleting the line init-piwigo-config/run#L50, the module works perfectly.

Expected Behavior

http://localhost:8080/plugins/OpenIdConnect/auth.php shouldn't raise an internal error.

Steps To Reproduce

  1. In Piwigo administration panel, install and enable the plugin OpenID Connect
  2. Edit the plugin configuration and add an Issuer URL, Client ID and Client secret. Check Enable Authorization Code Flow and save settings
  3. Logout
  4. Try to log in, the server respond with an internal error.

Environment

- OS: macOS 13.6.1
- How docker service was installed: I installed Docker Desktop using [Docker Desktop](https://docs.docker.com/desktop/install/mac-install/) installer

CPU architecture

arm64

Docker creation

I use the following Docker compose file:

version: "3"
services:
  piwigo-app:
    image: lscr.io/linuxserver/piwigo:13.8.0
    container_name: piwigo-app
    restart: unless-stopped
    volumes:
      - ./piwigo-app/config:/config
      - ./piwigo-app/gallery:/gallery
    env_file: .env
    networks:
      - piwigo-backend
    ports:
      - 8080:80

  piwigo-db:
    image: mariadb:10.11.2
    container_name: piwigo-db
    restart: unless-stopped
    volumes:
      - ./piwigo-db:/var/lib/mysql
    env_file: .env
    networks:
      - piwigo-backend

networks:
  piwigo-backend:
    name: piwigo-backend

Container logs

[migrations] started
[migrations] 01-nginx-site-confs-default: skipped
[migrations] done
───────────────────────────────────────

      ██╗     ███████╗██╗ ██████╗ 
      ██║     ██╔════╝██║██╔═══██╗
      ██║     ███████╗██║██║   ██║
      ██║     ╚════██║██║██║   ██║
      ███████╗███████║██║╚██████╔╝
      ╚══════╝╚══════╝╚═╝ ╚═════╝ 

   Brought to you by linuxserver.io
───────────────────────────────────────

To support LSIO projects visit:
https://www.linuxserver.io/donate/

───────────────────────────────────────
GID/UID
───────────────────────────────────────

User UID:    1000
User GID:    1000
───────────────────────────────────────

using keys found in /config/keys
[custom-init] No custom files found, skipping...
[ls.io-init] done.

In /config/log/nginx/error.log there is also an error:

2023/11/11 14:52:29 [error] 262#262: *3 FastCGI sent in stderr: "PHP message: PHP Warning:  require_once(../../include/common.inc.php): Failed to open stream: No such file or directory in /config/www/plugins/OpenIdConnect/auth.php on line 26PHP message: PHP Fatal error:  Uncaught Error: Failed opening required '../../include/common.inc.php' (include_path='.:/usr/share/php81') in /config/www/plugins/OpenIdConnect/auth.php:26
Stack trace:
#0 {main}
  thrown in /config/www/plugins/OpenIdConnect/auth.php on line 26" while reading response header from upstream, client: 192.168.65.1, server: _, request: "GET /plugins/OpenIdConnect/auth.php HTTP/1.1", upstream: "fastcgi://127.0.0.1:9000", host: "localhost:8080", referrer: "http://localhost:8080/"
Copy link

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

@LinuxServer-CI
Copy link
Collaborator

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@sequent5
Copy link

sequent5 commented Dec 20, 2023

same problem after upgrade piwigo from 13.1.0 to 14.0.0.

@GD-Dal
Copy link

GD-Dal commented Dec 25, 2023

Same issue her as well. Both v13 and v14

@GD-Dal
Copy link

GD-Dal commented Jan 18, 2024

Can this be added to the linuxserver Bug and PR Tracker?
Would have nice to see this fixed

@LinuxServer-CI
Copy link
Collaborator

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@tfmm
Copy link

tfmm commented Apr 9, 2024

Any updates on this one?

@homerr
Copy link
Member

homerr commented Apr 9, 2024

I've picked this up and will try to resolve. If it is indeed a symlink issue it may require some changes to how the container works.

@sequent5
Copy link

I've picked this up and will try to resolve. If it is indeed a symlink issue it may require some changes to how the container works.

I'is great! Thank you.

@LinuxServer-CI
Copy link
Collaborator

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@LinuxServer-CI LinuxServer-CI closed this as not planned Won't fix, can't repro, duplicate, stale Jul 10, 2024
Copy link

github-actions bot commented Aug 9, 2024

This issue is locked due to inactivity

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Development

No branches or pull requests

6 participants