Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] File drag and drop support #67

Closed
1 task done
Pastitas opened this issue May 28, 2024 · 8 comments
Closed
1 task done

[FEAT] File drag and drop support #67

Pastitas opened this issue May 28, 2024 · 8 comments

Comments

@Pastitas
Copy link

Is this a new feature request?

  • I have searched the existing issues

Wanted change

Add an togglable option to make the app upload automatically any files that are dragged and dropped there in the main page (maybe using some default upload folder setting) .

If this could somehow be integrated with the vnc host to drag the same file to the used application inside would be amazing but that seems way more complex, maybe that could be a future improvement

Reason for change

Right now there's no action associated with dragging and dropping files on kasmvnc webpage, instead the default action by the browser is done. Also in the settings menu there's an option for file upload that, when that specific window is open, allows for file uploads via drag and drop.

This makes sense for applications in which you'd normally want to drag and drop a file into, like https://github.com/linuxserver/docker-orcaslicer

Proposed code change

No response

@Pastitas Pastitas added the enhancement New feature or request label May 28, 2024
Copy link

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

@j0nnymoe
Copy link
Member

You would need to send this feature request to Kasm.

@Pastitas
Copy link
Author

Pastitas commented May 28, 2024

Opened an issue and was told that the kasmvnc is not the component that does this, so I assumed it was on your side
kasmtech/KasmVNC#250
Where can I open this then if its not there nor here?
It's unclear to me where the feature I'm currently using for uploads comes from

@j0nnymoe
Copy link
Member

Our baseimage consumes this repo: https://github.com/kasmtech/noVNC/ .

I'll tag in @thelamer as he'll have more knowledge on all this.
Side note to what you're wanting to do, I would suggest mounting an additional volume which you keep your 3d print files in.
Personally I have /models mounted which is shared with a few other things.

@Pastitas
Copy link
Author

Thanks, I've created an issue there and closed the other one, this might be closed then aswell when they confirm it's their feature
kasmtech/noVNC#109

@thelamer
Copy link
Member

The KasmVNC protocol does not have any file functionality that is something we bolt on with Kclient. Draggable overlay divs generally can block other specific interaction with the page depending on the browser (keyboard or mouse input) which is why it is scoped to the file browser modal.

@LinuxServer-CI
Copy link
Collaborator

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@LinuxServer-CI LinuxServer-CI closed this as not planned Won't fix, can't repro, duplicate, stale Aug 27, 2024
@LinuxServer-CI LinuxServer-CI moved this from Issues to Done in Issue & PR Tracker Aug 27, 2024
Copy link

This issue is locked due to inactivity

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Development

No branches or pull requests

4 participants