Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Add key bindings for window decoration #45

Closed
1 task done
stevenwfoley opened this issue Feb 29, 2024 · 4 comments
Closed
1 task done

[FEAT] Add key bindings for window decoration #45

stevenwfoley opened this issue Feb 29, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@stevenwfoley
Copy link

stevenwfoley commented Feb 29, 2024

Is this a new feature request?

  • I have searched the existing issues

Wanted change

Add the below described Decoration related key bindings to the section of the /etc/xdg/openbox/rc.xml file:
http://openbox.org/wiki/Help:Actions#ToggleDecorations

I'm mainly interested in the ToggleDecoration, but the other two would be nice for completeness.
I tested adding the entry to my local rc.xml file and it functions as expected.

Reason for change

Provide a quick method to remove and restore window decoration.

Proposed code change

<keybind key="A-S-d"> <action name="ToggleDecorations"/> </keybind> <keybind key="C-S-d"> <action name="Decorate"/> </keybind> <keybind key="C-S-d"> <action name="Undecorate"/> </keybind>

@stevenwfoley stevenwfoley added the enhancement New feature or request label Feb 29, 2024
@thelamer thelamer self-assigned this Mar 6, 2024
@thelamer thelamer transferred this issue from linuxserver/docker-firefox Mar 6, 2024
Copy link

github-actions bot commented Mar 6, 2024

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

@thelamer
Copy link
Member

thelamer commented Mar 6, 2024

Just so you know there is an env var for disabling decoration with -e NO_DECOR=true, but having a keyboard shortcut for this is not a bad idea by default in the base images.

@stevenwfoley
Copy link
Author

Thanks, I did find that variable, but the issue I ran into immediatly was a popup dialog in an app (firefox) went full screen, with no way to undecorate, so I was stuck. The hotkey would solve this.

@thelamer
Copy link
Member

This has been added to the baseimages it will take time to waterfall to everything downstream.

@LinuxServer-CI LinuxServer-CI moved this from Issues to Done in Issue & PR Tracker Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants