Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing partition for /home and /boot deletes the entire installation #362

Open
ShadowOfTheDark669 opened this issue Oct 31, 2024 · 2 comments

Comments

@ShadowOfTheDark669
Copy link

ShadowOfTheDark669 commented Oct 31, 2024

Bug
In the process of restoring a snapshot, if the root partition(empty) is MANUALLY selected for the /home and /boot directories instead of the Keep on root device option, then timeshift indeed restores the snapshot but deletes all the restored files followed by a Snapshot restored with errors popup. It attempts to mount /home and /boot both at / and deletes everything to do so, causing errors and an unrecoverable system. Checking with a file manager upon restore also ensures that the entire installation is deleted barring a few EMPTY folders.

To Reproduce
Steps to reproduce the behavior:

  1. Select a snapshot and click restore
  2. Select the root partition, then for the /home and /boot directories, which have Keep on root device by default, select the desired partition for root manually. Continue with the rest of the menus normally.
  3. Timeshift restores as expected but at the end of restoring, no of restored files is matched/exceeded to the no of deleted files.
  4. Snapshot restored with errors popup appears.

Expected behavior
Timeshift restores the snapshots normally.
Screenshots

Screenshot_20241101_171157
Screenshot_20241101_171414
Screenshot_20241101_171812

System:

  • Linux Distribution Name and Version: OpenSUSE Leap 15.6 , Fedora 40 and Void Linux Glibc
  • Desktop: KDE 6.2 , GNOME 46 , XFCE idk version
  • Application Version: 24.06.3 on Void Linux although issue appears on all the three distros.

Comments
Timeshift should atleast warn at the selection screen of this behaviour, or change the default behaviour to mount /boot and /home at / for the afore mentioned configuration instead of deleting everything. The only extremely subtle hint is at the second last conformation screen before restore.

@zahlman
Copy link

zahlman commented Nov 14, 2024

When you select a partition for the /home and /boot folders, you are asking for them to be restored at the root of the selected partition. "Keep on root partition" is a special case - the data goes to a subfolder on the partition where / is restored, i.e. is not configured for separate mounting.

Generally the UI should warn about, or prevent, restoring more than one of {/, /boot, /home} to the same partition, yes. I don't think it makes sense to do special cases instead - a user who wants /home data on the / partition can just re-select "Keep on root device".

@ShadowOfTheDark669
Copy link
Author

When you select a partition for the /home and /boot folders, you are asking for them to be restored at the root of the selected partition. "Keep on root partition" is a special case - the data goes to a subfolder on the partition where / is restored, i.e. is not configured for separate mounting.

Generally the UI should warn about, or prevent, restoring more than one of {/, /boot, /home} to the same partition, yes. I don't think it makes sense to do special cases instead - a user who wants /home data on the / partition can just re-select "Keep on root device".

Yep, I think warning or preventing such restore is better than the special case which I expressed in my post.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants