Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting validate_size = 0.0 doesn't behave correctly #171

Open
drewoldag opened this issue Jan 22, 2025 · 1 comment · May be fixed by #199
Open

Setting validate_size = 0.0 doesn't behave correctly #171

drewoldag opened this issue Jan 22, 2025 · 1 comment · May be fixed by #199
Assignees
@drewoldag
Labels
bug Something isn't working

Comments

@drewoldag
Copy link
Collaborator

Setting validate_size to 0 in the config should result in no validation run ocurring, but instead a validation run does happen.

In pytorch_ignite.py:dist_data_loader there's no check for whether the validate_size is 0. If this check was added, we should just return None for "no dataloader".
@drewoldag drewoldag added the bug Something isn't working label Jan 22, 2025
@drewoldag drewoldag self-assigned this Feb 4, 2025
@drewoldag
Copy link
Collaborator Author

This only affects the example cifar dataset

@drewoldag drewoldag linked a pull request Feb 5, 2025 that will close this issue
Protect against 0-length validation splits in cifar dataset #199
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drewoldag drewoldag

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Protect against 0-length validation splits in cifar dataset lincc-frameworks/fibad
1 participant
@drewoldag