Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SameSite to cookie X-AuthToken #516

Closed
ericlinagora opened this issue May 7, 2024 · 0 comments · Fixed by #522
Closed

Add SameSite to cookie X-AuthToken #516

ericlinagora opened this issue May 7, 2024 · 0 comments · Fixed by #522
Assignees
Labels
Milestone

Comments

@ericlinagora
Copy link
Contributor

Describe the bug
A warning in Firefox about future version requiring this in the header:

Cookie “X-AuthToken” does not have a proper “SameSite” attribute value. Soon, cookies without the “SameSite” attribute or with an invalid value will be treated as “Lax”. This means that the cookie will no longer be sent in third-party contexts. If your application depends on this cookie being available in such contexts, please add the “SameSite=None“ attribute to it. To know more about the “SameSite“ attribute, read https://developer.mozilla.org/docs/Web/HTTP/Headers/Set-Cookie/SameSite

Desktop (please complete the following information):

image

@shepilov shepilov added this to the v1.0.3 milestone May 7, 2024
@MontaGhanmy MontaGhanmy self-assigned this May 13, 2024
@MontaGhanmy MontaGhanmy linked a pull request May 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants