Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make deploy scripts more useful #40

Open
aguillon opened this issue Jan 22, 2024 · 0 comments
Open

Make deploy scripts more useful #40

aguillon opened this issue Jan 22, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@aguillon
Copy link
Contributor

Right now the script in deploy/ are only useful to quickly test that the contracts (actually, only one) can indeed be deployed on a Tezos network. However, the initial ledger, the metadata, the token metadata, etc. are all pre-set and so is the account originating the contract (although that does not matter much as there is no admin to this contract).

It could be useful to spend some time improving this contract so that users can effortlessly use it to deploy new tokens. This would require setting all the aforementioned data and reading the required information (secret key, etc.) from e.g. an environment variable.

I suggest to follow the example from the permit-cameligo repository. It would probably be more intuitive to configure every information (private key, RPC, and initial storage) in an ad-hoc JSON file.

Moreover, in the same spirit of building an extensible library than for the last PRs, it would be nice if such as script could be extended by projects using the library.

Doing this in TypeScript seems to make the most sense.

@aguillon aguillon added enhancement New feature or request good first issue Good for newcomers labels Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant