Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broadcast source error sound #16246

Open
loepare opened this issue Oct 20, 2024 · 5 comments
Open

Remove broadcast source error sound #16246

loepare opened this issue Oct 20, 2024 · 5 comments

Comments

@loepare
Copy link

loepare commented Oct 20, 2024

When being contributor to a broadcast, a nasty error sound occurs when a source error happens.
I thought for months that my headset was broken, because I couldn't match the sound to Lichess (I often have broadcasts open in the background). The personal story is not so important here, what I want to say is; I don't see the point of that sound, it doesn't really help much IMO.

@allanjoseph98
Copy link
Member

if (event.error) {
if (this.data.sync.log.slice(-3).every(e => e.error)) site.sound.play('error');
console.warn(`relay synchronisation error: ${event.error}`);

Plays after 3 consecutive sync errors. Don't think the console warning is useful either.

@SergioGlorias
Copy link
Contributor

The sound even has a reason: if the broadcaster has broadcast open, he will be alerted that there is an error.

It helps a lot to warn that the broadcaster has to act and not stay asleep

Although it currently does not warn of errors like it used to (missing or disordered chapters) which was more important

@loepare
Copy link
Author

loepare commented Oct 20, 2024

I understand the intention behind it, but I think most people wouldn't even understand that this sound is caused by the error of a lichess source.

@SergioGlorias
Copy link
Contributor

Note: this error only happens to those who are contributing to the round and not a global sound

@ornicar
Copy link
Collaborator

ornicar commented Oct 22, 2024

So? Keep or remove?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants