You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Generally, some parts of this firmware are not structured very well. For example, to my knowledge it is best practice for header files to only contain declarations, not definitions. In this way, the current structure of Input.h for example is not ideal. Such definitions should only be in c/cpp files ideally.
Some of the structure with regard to how these header files are included is also somewhat questionable, and may be unnecessary if they can be eliminated altogether in places.
Further to this, dependency files will now be moved into a src directory for the project, which will improve the structure and keep the base directory tidy.
Generally, some parts of this firmware are not structured very well. For example, to my knowledge it is best practice for header files to only contain declarations, not definitions. In this way, the current structure of
Input.h
for example is not ideal. Such definitions should only be in c/cpp files ideally.Some of the structure with regard to how these header files are included is also somewhat questionable, and may be unnecessary if they can be eliminated altogether in places.
See here.
The text was updated successfully, but these errors were encountered: