Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project structure #14

Open
jacobeva opened this issue Jul 16, 2024 · 1 comment
Open

Project structure #14

jacobeva opened this issue Jul 16, 2024 · 1 comment

Comments

@jacobeva
Copy link

jacobeva commented Jul 16, 2024

Generally, some parts of this firmware are not structured very well. For example, to my knowledge it is best practice for header files to only contain declarations, not definitions. In this way, the current structure of Input.h for example is not ideal. Such definitions should only be in c/cpp files ideally.

Some of the structure with regard to how these header files are included is also somewhat questionable, and may be unnecessary if they can be eliminated altogether in places.

See here.

@jacobeva
Copy link
Author

jacobeva commented Aug 1, 2024

Further to this, dependency files will now be moved into a src directory for the project, which will improve the structure and keep the base directory tidy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant