Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim DENYLIST.s390x #129

Open
iii-i opened this issue Jul 2, 2024 · 3 comments
Open

Trim DENYLIST.s390x #129

iii-i opened this issue Jul 2, 2024 · 3 comments

Comments

@iii-i
Copy link
Contributor

iii-i commented Jul 2, 2024

All tests listed in https://github.com/kernel-patches/bpf/blob/bpf-next_base/ci/vmtest/configs/DENYLIST.s390x pass in my development setup:

# ./test_progs -t deny_namespace,tc_redirect/tc_redirect_dtime,lru_bug,dummy_st_ops/dummy_init_ptr_arg,fexit_bpf2bpf,tailcalls,trace_ext,xdp_bpf2bpf,xdp_metadata
[...]
Summary: 9/34 PASSED, 0 SKIPPED, 0 FAILED

In particular, dummy_st_ops/dummy_init_ptr_arg was fixed by 7ded842b356d s390/bpf: Fix bpf_plt pointer arithmetic; unfortunately, the others don't have a bug report next to them. Should we empty this file? Or is there a list of bugs associated with the other entries somewhere else?

@chantra
Copy link
Collaborator

chantra commented Jul 2, 2024

The source of this file is https://github.com/kernel-patches/vmtest/blob/master/ci/vmtest/configs/DENYLIST.s390x

unfortunately, the best option if there is no clear comment as to why a test was added, is to check the associated commit in https://github.com/kernel-patches/vmtest/commits/master/ci/vmtest/configs/DENYLIST.s390x .

Should we empty this file?

SGTM, but we would need those to pass on both bpf and bpf-next branches as we may run the tests on one or the other branch. cc @anakryiko

@anakryiko
Copy link
Member

Should we empty this file?

SGTM, but we would need those to pass on both bpf and bpf-next branches as we may run the tests on one or the other branch. cc @anakryiko

yep, we should wait for bpf-next and bpf trees to converge before landing

@iii-i
Copy link
Contributor Author

iii-i commented Jul 2, 2024

Sounds good. Please ping me if they start failing again after that; I will investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants