-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The requested check was never run against this ref #29
Comments
Looks like using |
This has been working fine for the past few days and today it started failing. I haven't changed my config at all and I'm able to verify that the A few thoughts around what could be causing it.
|
Affecting me too |
I updated my jobs to use the |
Which SHA? The latest commit to master? @CWSites |
Correct, when you are dispatching a workflow you can pass a steps:
- name: Repository Dispatch
uses: peter-evans/repository-dispatch@v1
with:
token: ${{ secrets.REPO_ACCESS_TOKEN }}
repository: ${{ github.repository }}
event-type: run-lint-test-build
client-payload: '{"ref": "${{ github.ref }}", "sha": "${{ github.sha }}"}' After that you can use it like so steps:
- name: Checkout source code
uses: actions/checkout@v2
with:
ref: ${{ github.event.client_payload.sha }} |
Ah, with dispatch being an additional dependency. The documentation says that it won't work for non-default branches, so it looks like I will have to wait for this issue to be solved. |
It turns out I wasn't using the correct check. When I ran the api call with Still, that leaves no way to use this to wait for an entire extra workflow, only waiting on the individual jobs. |
I'm running mine against master on merge. If master is your default branch then you could make this work. If you supply a name that will overwrite whatever weird thing that it's using. |
Where does it say that it won't work for non-default branches? I saw that it won't work for other repositories but not branches. |
I can't find anywhere in the documentation for this workflow which states that the default branch must be used. I updated my default to be I have verified that the Dispatch job is using the same Dispatch Config verification:
name: Dispatch - Lint, Test & Build
runs-on: ubuntu-latest
steps:
- name: Repository Dispatch
uses: peter-evans/repository-dispatch@v1
with:
token: ${{ secrets.REPO_ACCESS_TOKEN }}
repository: ${{ github.repository }}
event-type: run-lint-test-build
client-payload: '{"ref": "${{ github.ref }}", "sha": "${{ github.sha }}"}' Wait Configname: Lint, Test & Build
on:
workflow_dispatch:
repository_dispatch:
types: [run-lint-test-build]
jobs:
verification:
name: Lint, Format & Build # used for check-name on version.yml
runs-on: ubuntu-latest
steps:
- name: Checkout source code
uses: actions/checkout@v2
with:
ref: ${{ github.event.client_payload.sha }}
- run: echo using SHA ${{ github.event.client_payload.sha }}
- name: Setup Node.js
uses: actions/setup-node@v1
with:
node-version: 12
# https://github.com/marketplace/actions/yarn-install-cache
- name: Cache yarn dependencies
uses: c-hive/gha-yarn-cache@v1
- name: Install dependencies
run: yarn install
- name: Lint Code
run: yarn lint
- name: Code Format Check
run: yarn format:check --verbose
- name: Build
run: yarn build
env:
CI: true |
Closing this one in favor of #30 since the original issue has been resolved. |
@progapandist I'm having this exact issue even when I change to using the |
Likewise ^ @karkir0003 Have you figured out a fix/workaround? |
I think I was able to resolve this issue. I needed to add
This structure worked for me @vezaynk |
I figured out a better way of doing this in bash and jq. Here is an example of a script that doesn't complete until all jobs are completed on master: until gh run list -R my/repo -b master --json status | jq '[.[].status] | unique' | jq '. - ["in_progress", "queued", "completed"]' | jq -e '.[0]'
do
echo "Waiting...";
sleep 2;
done |
@progapandist if you have a moment can you please help me out?
github.sha
master
but now it's not working with my default branch set todevelop
?@master
so that I have latest.I'm running into the same problem as #7 and using the sha
bafe56a6863672c681c3cf671f5e10b20abf2eaa
which should have fixed it, so I'm not sure if it was reintroduced or if I'm doing it wrong.Update: I used
@master
andgithub.sha
which fixed the issue I was having. However now that I changed my default branch to bedevelop
I'm having issues, see comments further down.This is my config
This is the workflow that I'm waiting on
The text was updated successfully, but these errors were encountered: