Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider image name/tag in light of managing different app environments #11

Open
rsyring opened this issue Jun 18, 2024 · 0 comments
Open

Comments

@rsyring
Copy link
Member

rsyring commented Jun 18, 2024

One of the intentions of mu is that you can easily deploy multiple lambdas into the same AWS environment without conflict. This seems helpful, in particular, for being able to deploy/test different branches.

However, currently, we don't take the environment into account when creating images. So, the following sequence could result in accidentally deploying a dev branch to production:

  1. Make changes on some-dev-branch, commit, provision/build/deploy with 'some-dev-branch' as the name
  2. Switch to master / main, make a hot fix, deploy to prod (forgetting to build first)

The image sent to prod is now the last image built on the local system, which is the one for some-dev-branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant