Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When should the database record be deleted, when a course is triggered? #4

Open
tobiasreischmann opened this issue Aug 23, 2017 · 0 comments

Comments

@tobiasreischmann
Copy link
Contributor

We already discussed about this earlier. I am still not satisfied with the way handle_course() first removes the database record from your db table and then returning true, without the guarantee that the process is actually triggered.
I would suggest to add events to the core API, when a process for a course is triggered. Then you could listen for this event and remove the db entry only in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants