Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testId support to picker items #495

Closed
LoserAntbear opened this issue Jan 4, 2023 · 2 comments
Closed

Add testId support to picker items #495

LoserAntbear opened this issue Jan 4, 2023 · 2 comments

Comments

@LoserAntbear
Copy link

Is your feature request related to a problem? Please describe.

Picker itself provide testId support, but items do not have it. For the sake of improvement of testing of the components testId support should be added.

Describe the solution you'd like

A testId prop should be added to the item in renderer method. Interestingly,PickerItem component already has it, but renderItem method does not propagate it.

Describe alternatives you've considered

For now the easies solution is a monkeypatch, but it's the last resort.

Additional details

Missing prop propagation
image
Proof of support of testID prop by Item component
image

@LoserAntbear
Copy link
Author

I'd like to commit to this, if approved.

@lfkwtz
Copy link
Collaborator

lfkwtz commented Aug 28, 2023

#498

@lfkwtz lfkwtz closed this as completed Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants