Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binning Summation #235

Open
pbonazzi opened this issue Sep 11, 2023 · 2 comments
Open

Binning Summation #235

pbonazzi opened this issue Sep 11, 2023 · 2 comments
Labels
0-needs-review

Comments

@pbonazzi
Copy link

pbonazzi commented Sep 11, 2023 •
edited
Loading

Can you clarify this binning mode summation?
Shouldn't we use torch.index_add_ ? Otherwise there is no difference between binningmode SUM and OR

https://github.com/lava-nc/lava-dl/blob/185edfe9fb035e13c24eec063a4971ccb0956d3a/src/lava/lib/dl/slayer/io.py#L234C1-L241C38
@bamsumit
Copy link
Contributor

Hi @pbonazzi I am guessing you are meaning to say SUM mode and OR mode. Yes the current implementation seems to be a bug. Would you like to make a correction PR?

@pbonazzi
Copy link
Author

Yes, I can do it over the weekend.

@pbonazzi pbonazzi mentioned this issue Sep 30, 2023
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0-needs-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bamsumit @pbonazzi