Desktop,Mobile: Allow internal links to target elements using the name attribute #11671
+20
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes a regression from #11591, which disallowed the
name
attribute in rendered HTML. For example,By rewriting
name="some-name-here"
toid="some-id-here"
, this pull request restores the ability to jump to elements based on the user-specifiedname
attribute.Note
This pull request fixes a regression and thus targets
release-3.2
.This regression was reported on the Joplin forum.
Testing
Automated testing: This pull request adjusts an existing automated test.
Manual testing: