Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo for basic proxy auth header #718

Closed
Alex-Cebula opened this issue Dec 19, 2024 · 1 comment · Fixed by #720 · May be fixed by #721
Closed

Typo for basic proxy auth header #718

Alex-Cebula opened this issue Dec 19, 2024 · 1 comment · Fixed by #720 · May be fixed by #721
Labels
bug Something isn't working package: sdk/server-node Label for issues affecting the sdk/server-node package.

Comments

@Alex-Cebula
Copy link

On line 60 of NodeRequest.ts it looks like there's one too many '}' characters in the value of the proxy authorization header. I would think this would cause proxies to not work for node users of this package since their credentials have an extra unexpected character.
@Alex-Cebula Alex-Cebula added bug Something isn't working package: sdk/server-node Label for issues affecting the sdk/server-node package. labels Dec 19, 2024
@kinyoklion
Copy link
Member

Hello @Alex-Cebula,

Thank you for the report. I will take a look.

Filed internally as SDK-1017

@kinyoklion kinyoklion mentioned this issue Dec 19, 2024
Merged
@github-actions github-actions bot mentioned this issue Dec 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working package: sdk/server-node Label for issues affecting the sdk/server-node package.
Projects
None yet
Milestone
No milestone
2 participants
@kinyoklion @Alex-Cebula