From d022b5880551ffbb9f3b8ee791a085529e871230 Mon Sep 17 00:00:00 2001 From: Jaz White Date: Thu, 3 Aug 2023 11:10:31 -0400 Subject: [PATCH] design: update emojis used (#43) --- comments/comments.go | 4 ++-- comments/comments_test.go | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/comments/comments.go b/comments/comments.go index e5454e2c..060a8fbc 100644 --- a/comments/comments.go +++ b/comments/comments.go @@ -81,7 +81,7 @@ func BuildFlagComment(buildComment FlagComments, flagsRef lflags.FlagsRef, exist numFlagsAdded := len(flagsRef.FlagsAdded) if numFlagsAdded > 0 { - commentStr = append(commentStr, fmt.Sprintf("### :green_circle: %s added or modified\n", pluralize("flag reference", numFlagsAdded))) + commentStr = append(commentStr, fmt.Sprintf("### :mag: %s added or modified\n", pluralize("flag reference", numFlagsAdded))) commentStr = append(commentStr, tableHeader) commentStr = append(commentStr, buildComment.CommentsAdded...) commentStr = append(commentStr, "\n") @@ -89,7 +89,7 @@ func BuildFlagComment(buildComment FlagComments, flagsRef lflags.FlagsRef, exist numFlagsRemoved := len(flagsRef.FlagsRemoved) if numFlagsRemoved > 0 { - commentStr = append(commentStr, fmt.Sprintf("### :red_circle: %s removed\n", pluralize("flag reference", numFlagsRemoved))) + commentStr = append(commentStr, fmt.Sprintf("### :x: %s removed\n", pluralize("flag reference", numFlagsRemoved))) commentStr = append(commentStr, tableHeader) commentStr = append(commentStr, buildComment.CommentsRemoved...) } diff --git a/comments/comments_test.go b/comments/comments_test.go index 7a9daff0..60d69217 100644 --- a/comments/comments_test.go +++ b/comments/comments_test.go @@ -176,7 +176,7 @@ func (e *testCommentBuilder) AddedOnly(t *testing.T) { e.Comments.CommentsAdded = []string{"comment1", "comment2"} comment := BuildFlagComment(e.Comments, e.FlagsRef, nil) - expected := "## LaunchDarkly flag references\n### :green_circle: 1 flag reference added or modified\n\n| Name | Key | Aliases found |\n| --- | --- | --- |\ncomment1\ncomment2\n\n\n \n " + expected := "## LaunchDarkly flag references\n### :mag: 1 flag reference added or modified\n\n| Name | Key | Aliases found |\n| --- | --- | --- |\ncomment1\ncomment2\n\n\n \n " assert.Equal(t, expected, comment) } @@ -186,7 +186,7 @@ func (e *testCommentBuilder) RemovedOnly(t *testing.T) { e.Comments.CommentsRemoved = []string{"comment1", "comment2"} comment := BuildFlagComment(e.Comments, e.FlagsRef, nil) - expected := "## LaunchDarkly flag references\n### :red_circle: 2 flag references removed\n\n| Name | Key | Aliases found |\n| --- | --- | --- |\ncomment1\ncomment2\n \n " + expected := "## LaunchDarkly flag references\n### :x: 2 flag references removed\n\n| Name | Key | Aliases found |\n| --- | --- | --- |\ncomment1\ncomment2\n \n " assert.Equal(t, expected, comment) } @@ -197,7 +197,7 @@ func (e *testCommentBuilder) AddedAndRemoved(t *testing.T) { e.Comments.CommentsRemoved = []string{"comment1", "comment2"} comment := BuildFlagComment(e.Comments, e.FlagsRef, nil) - expected := "## LaunchDarkly flag references\n### :green_circle: 1 flag reference added or modified\n\n| Name | Key | Aliases found |\n| --- | --- | --- |\ncomment1\ncomment2\n\n\n### :red_circle: 1 flag reference removed\n\n| Name | Key | Aliases found |\n| --- | --- | --- |\ncomment1\ncomment2\n \n " + expected := "## LaunchDarkly flag references\n### :mag: 1 flag reference added or modified\n\n| Name | Key | Aliases found |\n| --- | --- | --- |\ncomment1\ncomment2\n\n\n### :x: 1 flag reference removed\n\n| Name | Key | Aliases found |\n| --- | --- | --- |\ncomment1\ncomment2\n \n " assert.Equal(t, expected, comment)