Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amsmath: suspicious \@arrayboxrestore #1608

Open
nbeisert opened this issue Jan 6, 2025 · 1 comment
Open

amsmath: suspicious \@arrayboxrestore #1608

nbeisert opened this issue Jan 6, 2025 · 1 comment
Assignees
Labels
bug category amsmath fixed in dev Fixed in development branch, not in stable release

Comments

@nbeisert
Copy link

nbeisert commented Jan 6, 2025

This is a very brief report: amsmath.dtx makes a suspicious definition of \@arrayboxrestore as follows:

\edef\@arrayboxrestore{\the\toks@}

Issues:

  • I could not find any other reference to \@arrayboxrestore in amsmath or any other package in my latex installation (grep -R @arrayboxrestore).
  • This definition hardly makes sense as is.
  • \@arrayboxrestore extends the definition of \@arrayparboxrestore in the previous line:
    \toks@\@xp{\@arrayparboxrestore \let\label\ltx@label}%
  • Shouldn't \@arrayboxrestore be \@arrayparboxrestore? With the suggested change, the intention of this pair of lines appears straight-forward: append \let\label\ltx@label to \@arrayparboxrestore in place.
  • I have no idea about the practical implications (of implementing the change or discarding it).
@u-fischer
Copy link
Member

looks definitively like a typo. Which probably shows that nobody uses a labeled enumerate inside a minipage inside an equation ...

@github-project-automation github-project-automation bot moved this to Pool (unscheduled issues) in upcoming LaTeX2e releases Jan 6, 2025
@FrankMittelbach FrankMittelbach self-assigned this Jan 10, 2025
@FrankMittelbach FrankMittelbach added this to the Release 2025 Spring milestone Jan 10, 2025
FrankMittelbach added a commit that referenced this issue Jan 11, 2025
@FrankMittelbach FrankMittelbach moved this from Pool (unscheduled issues) to Done in dev in upcoming LaTeX2e releases Jan 11, 2025
FrankMittelbach added a commit that referenced this issue Jan 11, 2025
* fix for #1608

* cleanup change entry
@FrankMittelbach FrankMittelbach added fixed in dev Fixed in development branch, not in stable release and removed fixed in branch labels Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug category amsmath fixed in dev Fixed in development branch, not in stable release
Projects
Status: Done in dev
Development

No branches or pull requests

3 participants