Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game id missing by default, preventing reports from being generated #36

Open
mastef opened this issue Aug 24, 2016 · 3 comments
Open

Game id missing by default, preventing reports from being generated #36

mastef opened this issue Aug 24, 2016 · 3 comments

Comments

@mastef
Copy link

mastef commented Aug 24, 2016

It seems ERROR_PROJECTNAME in the php server is by default set to game id which the client never sends

define("ERROR_PROJECTNAME", "game id");

Since strlen($project) returns 0, the error never gets submitted

if ((strlen($exception) || strlen($file) || strlen($function)) && strlen($project)) {

What worked in my case was changing the value to "package"

define("ERROR_PROJECTNAME", "package");

@IBwWG
Copy link

IBwWG commented Aug 27, 2016

I fixed this in 97e84bf using "sess.ID" instead :)

@mastef
Copy link
Author

mastef commented Aug 27, 2016

Don't think sess.ID is the right one in this case as it'd be always unique?

@IBwWG
Copy link

IBwWG commented Aug 27, 2016

You'd think so from the name...IIRC though it's not exactly so. I'd have to look again, but at the moment it does seem to be doing the right thing this way, somehow--I have one project per project in the server browser, not one per session. (And I have about 90 crashes spanning several versions.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants