Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alphanumeric Sender IDs missing documentation #149

Open
ace-of-aces opened this issue Nov 20, 2024 · 1 comment
Open

Alphanumeric Sender IDs missing documentation #149

ace-of-aces opened this issue Nov 20, 2024 · 1 comment

Comments

@ace-of-aces
Copy link

When I tried adding an alphanumeric sender ID to a Twilio notification, I had to dig through the source code of this package to find out that the Notifiable must have a canReceiveAlphaNumericSender function that returns true in order for the sender ID to be respected. I could not find this anywhere in the documentation.

Also, the PHPDoc description of the from method in the TwilioMessage only states "Set the phone number the message should be sent from.", although that this could also be an alphanumeric sender ID.

I found this to be quite inconvenient to work with, so I would propose for this to be properly documented. I'd be happy to create PRs for these!

@lrljoe
Copy link

lrljoe commented Nov 28, 2024

Keep in mind how alphanumeric senders work, and that not all destinations can receive them.

Some countries require pre-registration of the alphanumeric sender as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants