Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bypassing capture-output has unexpected behavior when running in REPL #446

Open
alexhall opened this issue Sep 13, 2024 · 0 comments · May be fixed by #447
Open

Bypassing capture-output has unexpected behavior when running in REPL #446

alexhall opened this issue Sep 13, 2024 · 0 comments · May be fixed by #447

Comments

@alexhall
Copy link

Using the capture/bypass macro works as expected when running tests in the CLI. When running in the REPL (e.g. via cider-jack-in), however, I'm finding that the behavior is not as I would have expected. Namely, the fact that output goes directly to the process stdout/stderr streams means that when running tests in the REPL, output from this macro goes to the NREPL server's output buffer. Ideally this output would instead be written to the writers that NREPL installs in order to capture output, to be returned to the NREPL client and displayed in the Cider buffer.

One potential approach here would be to make the previous bindings for *out* and *err* available via bindings, and have the bypass macro detect and restore these rather than always going to the process file descriptors.

@alexhall alexhall linked a pull request Sep 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

1 participant